[darcs-users] darcs patch: partial type witnesses in Unrevert (and 44 more)

[David Roundy]

On Wed, Aug 27, 2008 at 10:53:27AM -0700, Jason Dagit wrote:
> On Wed, Aug 27, 2008 at 10:35 AM, David Roundy <droundy at darcs.net> wrote:
> > On Wed, Aug 27, 2008 at 09:56:32AM -0700, Jason Dagit wrote:
> >> David,
> >>
> >> This is the resend you requested.
> >>
> >> I can't be sure that the individal patches below will compile by themselves, but
> >> I know they result in a working darcs when applied together.  Hopefully,
> >> sending like this will make it easier for you to review them!
> >
> > I know it's a lot of work, but breaking these into managable chunks
> > that *will* compile may be the only way to get this actually
> > reviewed.  And this really is important, because I'm pretty confident
> > that in a change of this magnitude, there *will* be bugs present.  And
> > the type witness don't really help us in this, because most of the
> > code involved uses functions with wrong type witnesses--which is to
> > say, the functions in Darcs.Repository, which cannot be written with
> > correct type witnesses until we've got something that can handle
> > mutable state.  Which means that the code need to be reviewed, and
> > therefore needs to be presented in a comprehensible format.
> >
> > This one still has a conflict in it, so I can't apply this one without
> > the resolution patch--which isn't labelled.
>
> It's in the bundle:
>
> Tue Aug 26 21:13:21 PDT 2008  Jason Dagit <dagit at codersbase.com>
>  * fix conflicts with get_extra changes

I found it right after I sent this message, and felt pretty stupid.
:(  Sorry!

David