[darcs-users] darcs patch: Code for checking for filenames consider... (and 1 more)

David Roundy droundy at darcs.net
Sat Aug 30 16:01:46 UTC 2008


On Sat, Aug 30, 2008 at 04:00:11AM -0700, Eric Kow wrote:
> This isn't used yet, but I thought it may speed
>   http://bugs.darcs.net/issue53
> if I added it to the repository
> 
> Sat Aug 30 11:55:13 BST 2008  Eric Kow <E.Y.Kow at brighton.ac.uk>
>   * Code for checking for filenames considered reserved on Windows.
>   This was written by Kannan Goundan for http://bugs.darcs.net/issue53
> 
> Sat Aug 30 11:59:13 BST 2008  Eric Kow <E.Y.Kow at brighton.ac.uk>
>   * Slightly tidy up Windows reserved file name code.

Applied.  But I'd far prefer to see type ErrorReason = String removed.  If
we want a clearer return type than Maybe String, we should use an actual
data type, e.g.

data ErrorResult = Error String | NoError

This is a little tedious, but far better, as "Nothing" is the conventional
error result in the Maybe monad.

David


More information about the darcs-users mailing list