[darcs-users] darcs patch: some cabal fixes for 2.2

[Trent W. Buck]

On Sun, Dec 21, 2008 at 11:22:17PM -0500, Judah Jacobson wrote:
> On Wed, Dec 17, 2008 at 6:55 PM, Trent W. Buck <trentbuck at gmail.com> wrote:
>>
>> Can it read my ~/.inputrc yet? ;-)
>> I'm awfully fond of
>>
>>    $if mode=emacs
>>      # poor-man's insert-parentheses
>>      (: "\C-v(\C-v)\C-b"
>>      [: "\C-v[\C-v]\C-b"
>>      {: "\C-v{\C-v}\C-b"
>>      }: forward-char
>>      ]: forward-char
>>      ): forward-char
>>    $endif
>
> As of 0.5.0.1, you can do that: (although not with the exact .inputrc
> notation :-)
> http://trac.haskell.org/haskeline/wiki/CustomKeyBindings

Hmm, should it read .editrc then? ;-)

(IIRC that's the file used by editline, a non-infective readline
clone.)

> Thanks for the suggestion!
>
>>> It might be worth bumping up the dependency to haskeline-0.5 for
>>> darcs-2.2; it could use a little more testing, but no code changes
>>> would be necessary since the part of the API that darcs uses has
>>> stayed the same.  I'll send a patch/proposal once the testing/bugfixes
>>> are completed.
>>
>> Is there any reason it won't work with 0.4?  Why not just increase the
>> ceiling (>= 0.4 && <= 0.5), rather than the floor as well (== 0.5)?
>> That's what I get told to do for Debian package dependencies, because it
>> makes it easier to "backport" (i.e. cherry pick) new upstream of a
>> critical package into an otherwise stable OS.
>>
>> (Easier because the backporter doesn't have to override the dependency,
>> nor backport extra library packages.)
>
> The only issue I can think of is that people building with 0.3.* or
> 0.4.* might miss out on some haskeline bug fixes (such as the encoding
> issue mentioned a few days ago).

Sure, but it should be their choice when to upgrade haskeline.  They
shouldn't need the bugfixes to build Darcs (unless those bugs actually
break Darcs, that is).

Just to clarify: I'm not necessarily saying anyone would do this, just
that it's the mindset I'm used to.

> But probably that's fine since the common use case "cabal install
> darcs" will update haskeline to the latest version anyway.

Yup.