[darcs-users] darcs patch: Fix a memory leak in Darcs.Repository.Repair.

[Petr Rockai]

Hi,

this I consider the final (to be applied) version of the patch. I am deferring
the witness issue, since the Repository.Repair module uses unsafe operations
elsewhere and therefore does not compile with witnesses no matter the
changes. It'll likely be quite laborious to convert it to witnesses and I would
like to see the fix applied in a timely manner. I will try to address the
witness question post-release.

This brings me to another point: I nominate this patch for 2.2 on the grounds
of "meeting release goals". This means it needs fairly careful review and some
more testing than it has gotten -- I currently only tried it on darcs repo
itself (not corrupted) and it passes my new repair-corrupt (for which I'll have
to come up with a fix... I'll send that in a minute). I am "reasonably" sure it
does the right thing, which is of course not enough.

Kowey, I delegate the task of picking the right reviewer(s) to you, hopefully
we'll be able to get this through in time
.
Thanks,
   Petr.

Tue Dec 23 13:22:27 CET 2008  Petr Rockai <me at mornfall.net>
  * Fix a memory leak in Darcs.Repository.Repair.
    
  The way we repaired patches forced the whole repository into memory. We now
  only store patches that we have actually changed and "zip" them back into the
  repository using replaceInFL.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: text/x-darcs-patch
Size: 85906 bytes
Desc: A darcs patch for your repository!
Url : http://lists.osuosl.org/pipermail/darcs-users/attachments/20081223/79480efa/attachment-0001.bin