[darcs-users] darcs patch: ./src/ByteStringUtils.hs: remove trailin... (and 64 more)

Gwern Branwen gwern0 at gmail.com
Tue Dec 23 18:00:57 UTC 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On Tue, Dec 23, 2008 at 12:37 PM, Eric Kow  wrote:
> On Tue, Dec 23, 2008 at 12:34:52 -0500, Gwern Branwen wrote:
>> > (My request was really just to not produce any new trailing whitespace,
>> >  not to get rid of a whole lot of it.  It seems like the right approach
>> >  to the latter is just to sneak them in to any patches you make, i.e.
>> >  if you have to touch a line that's got trailing whitespace in it anyway,
>> >  then by all means go ahead and kill it, otherwise, leave it alone)
>>
>> Funnily enough, on other projects I get yelled at for just that.
>
> Really? :-) What's their justification?

Generally the complaint is something like 'your patches are hard to
read because of the whitespace changes; don't do that then'.
(Particularly true of Yi.)

> I think mine is something like
> "mumble mumble commute mumble" (I guess that argument could be addressed
> by submitting lots of little ws patches like you did, but then we're
> polluting the history).

There's no winning, is there. :( One big patch doesn't commute, and a
lot of little patches pollutes the history, and mixing it into other
changes is unclear.

(Wonder if the same objections would hold for hlint.)

> Anyway, let me stress that I don't consider this a big deal, just
> something I like to pick on because it's easy.

And creating those patches was easy, between sed and Emacs's macros.

- --
gwern
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEAREKAAYFAklRJ1cACgkQvpDo5Pfl1oKOfACfVPaSZ0k2XetfX1ABDr32VB/p
nPIAnjPjHrpZyKJk9IgeICgAMQcAQgGB
=HP2W
-----END PGP SIGNATURE-----


More information about the darcs-users mailing list