[darcs-users] darcs patch: Fix UI bug in rollback. (and 1 more)

David Roundy droundy at darcs.net
Wed May 21 12:30:34 UTC 2008


On Wed, May 21, 2008 at 12:09:24PM +0000, E.Y.Kow at brighton.ac.uk wrote:
> Wed May 21 13:03:59 BST 2008  Eric Kow <E.Y.Kow at brighton.ac.uk>
>   * Fix UI bug in rollback.
>   It did not notice if you do not select any changes to roll back.
> 
> Wed May 21 13:08:56 BST 2008  Eric Kow <E.Y.Kow at brighton.ac.uk>
>   * Generalise test for rollback with no changes.
...
>                 existing_files (effect ps) $ \ (_:>ps'') ->
> -         do when (nullFL ps) $ do logMessage "No changes selected!"
> -                                  exitWith ExitSuccess
> +         do when (nullFL ps'') $ do logMessage "No changes selected!"
> +                                    exitWith ExitSuccess
>              let make_log = world_readable_temp "darcs-rollback"
>                  newlog = Just ("", "":"rolling back:":"":lines (show $ summary ps ))
>              --tentativelyRemovePatches repository opts (mapFL_FL hopefully ps)

You need to check that --edit wasn't passed, otherwise this is a UI
regression.

David


More information about the darcs-users mailing list