[darcs-users] darcs patch: haddockification of Printer

[Florent Becker]

Eric Kow <kowey <at> darcs.net> writes:

> 
> On Thu, Oct 02, 2008 at 18:00:52 -0400, David Roundy wrote:
> > On Thu, Oct 02, 2008 at 09:54:53PM +0200, Florent Becker wrote:
> > > +-- | 'invisiblePrinter' is the 'Printer' for invisible text. It just 
replaces the
> > > +-- document with 'empty'.
> > 
> > This isn't accurate.  Invisible text is sometimes printed, it's just
> > not printed to the screen.  If it were always empty, it wouldn't be
> > very useful.  I could grep the code and figure out how this works, but
> > that's what you're doing, right?
> 
> I'll just take this opportunity to trot out
>   http://wiki.darcs.net/index.html/DarcsInternals
> and specifically
>   http://lists.osuosl.org/pipermail/darcs-devel/2007-November/006441.html
> (which may itself be inaccurate)
> 
> I am really heartened to see the progress we're making spreading the
> understanding of darcs internals!  Honest mistakes are really good for
> us; they give us a chance to spread knowledge in delicate places :-D
> 

Sorry, in my precipitation i forgot to say that these patches reflect what I 
understand from the code, and that as for this module, I was not positively 
sure of everything. I was implicitly counting on your review, but better make 
it explicit.

Is it ok with you if I send a first version of each patch where I tag strings 
I'm not sure of, or questions I have? These would of course not be for 
application on darcs.net, just for review and to start discussion. Then I would 
resend a definitive version. If you don't have time to answer, then I can just 
delete the unsure strings in the definitive version.

You in the previous paragraph represents the darcs community, not just 
david/eric, of course.

Florent