[darcs-users] darcs patch: resolve issue1111: use correct side of return from partitionRL

David Roundy droundy at darcs.net
Sat Oct 4 11:49:27 UTC 2008


Yes, it's missing.  From Tommy's description it looks like it's probably a
correct fix, so hopefully he can resend soon.  :) Thanks, Tommy!

David

On Fri, Oct 03, 2008 at 11:41:02PM -0700, Jason Dagit wrote:
> Is it just me, or is the actual patch bundle missing here?
> 
> Jason
> PS. I hope it's missing as I'm not ready to be crazy, yet.
> 
> On Fri, Oct 3, 2008 at 4:48 PM, Tommy Pettersson <ptp at lysator.liu.se> wrote:
> 
> > This fix being in Darcs/Patch/ makes me a bit uncomfortable, but
> > it should be rather straight forward. From reading the code for
> > partitionRL it is clear it puts the interesting (common, in this
> > case) patches to the right, but patchset_intersection wrongly
> > picked the left side (which would have been the complement of
> > common patches from one of the sets).
> >
> >
> > Sat Oct  4 01:12:44 CEST 2008  Tommy Pettersson <ptp at lysator.liu.se>
> >  * resolve issue1111: use correct side of return from partitionRL
> >
> > Sat Oct  4 01:03:23 CEST 2008  Tommy Pettersson <ptp at lysator.liu.se>
> >  * use longer patch names in issue1111 test for safer grep result
> >  The 'not grep C out' found the author--date line of patch A, which
> >  contained my timezone (CEST), so the test failed even when it should have
> >  succeeded.
> >
> >
> >

> _______________________________________________
> darcs-users mailing list
> darcs-users at darcs.net
> http://lists.osuosl.org/mailman/listinfo/darcs-users


-- 
David Roundy
http://www.darcs.net


More information about the darcs-users mailing list