[darcs-users] darcs patch: Add Patch-salt as ignored prefix

Tommy Pettersson ptp at lysator.liu.se
Sat Oct 4 12:29:08 UTC 2008


On Sat, Oct 04, 2008 at 07:58:11AM -0400, David Roundy wrote:
> On Thu, Oct 02, 2008 at 09:36:36PM -0400, Max Battcher wrote:
> > I apologize for not compiling/testing this patch, but I've still yet to 
> > completely set-up darcs' building on this laptop...
> > 
> > However, this is a simple one-line change that changes a small data
> > structure and I'm sure that it should compile.
> > 
> > 
> > Thu Oct  2 18:44:10 EDT 2008  Max Battcher <me at worldmaker.net>
> >   * Add Patch-salt as ignored prefix
> >   
> >   Adds "Patch-salt: " as an ignored prefix in patch descriptions as a more
> >   semantic alternative to "Ignore-this: " for patch differentiation as
> >   proposed to solve issue1102.
> 
> I don't like this change.  Ignore-this is a more general statement, which
> means we can reuse it for anything we like.  On the other hand, if there is
> a universal desire to call this junk Patch-salt, we can do that.

Since no one is normally going to see it anyway it could be
obnoxiously named Ignore-this-patch-salt:, with future additions
like Ignore-this-hash-signature:,
Ignore-this-<mytool>-<my>-<fancy>-<metadata>:, etc.

That will also lower the risk of anyone entering it in a long
comment by mistake.


-- 
Tommy Pettersson <ptp at lysator.liu.se>


More information about the darcs-users mailing list