[darcs-users] darcs patch: refactor of SelectChanges (and 1 more)

David Roundy droundy at darcs.net
Tue Oct 7 15:26:09 UTC 2008


On Tue, Oct 07, 2008 at 03:47:50PM +0200, Florent Becker wrote:
> hunk ./src/Darcs/SelectChanges.lhs 76
> +data WhichChanges = Last | LastReversed | First | FirstReversed deriving (Eq, Show)
> +
> +type MatchCriterion p = FORALL(u v) WhichChanges -> [DarcsFlag] -> (p C(u v)) -> Bool

I'd also strongly encourage you not to use type like this.  It makes
the code more non-local to read, as one has to keep looking up to find
out what this means.  Type synonymns aren't always wrong, but they
usually are.

David


More information about the darcs-users mailing list