[darcs-users] darcs patch: fixed accidental merge of two lines in default boring

[Trent W. Buck]

Ben Franksen <benjamin.franksen at bessy.de> writes:

> David Roundy wrote:
>> On Tue, Oct 07, 2008 at 05:51:34PM +0200, ben.franksen at online.de wrote:
>>> Resending this patch. It's uncontroversial, I think.
>>> 
>>> Wed Oct  1 22:18:38 CEST 2008  ben.franksen at online.de
>>>   * fixed accidental merge of two lines in default boring
>>> 
>> 
>> Content-Description: A darcs patch for your repository!
>>> 
>>> New patches:
>>> 
>>> [fixed accidental merge of two lines in default boring
>>> ben.franksen at online.de**20081001201838] hunk
>>> ./src/Darcs/Repository/Prefs.lhs 135
>>>                    "\\.tix$", -- Haskell Program Coverage
>>>                    "\\.mod$", -- FORTRAN module files
>>>                    "\\.installed-pkg-config", "\\.setup-config",
>>> -                  "\\.setup-config^dist(/|$)", -- Cabal intermediates
>>> +                  "\\.setup-config","^dist(/|$)", -- Cabal intermediates
>>>                    "# *.ko files aren't boring by default because they
>>>                    might", "# be Korean translations rather than kernel
>>>                    modules.", "# \\.ko$",
>> 
>> Actually, I think it's inappropriate to ignore dist directories.  It
>> seems like a perfectly reasonable directory name to me.
>
> It is the name of the directory that cabal uses for building. So, at least
> for Haskell programmers, it is a natural candidate for boring.

I think there's too much potential for "dist" to be a legitimate
directory.  Therefore I'd change the default boring to contain

    # A top-level dist/ is boring for Haskell users, but might not be
    # for everybody.
    # ^dist(/|$)

To me, it's the same case as you might make for ignoring "build/".

BTW, why aren't comments about what the regexps are for being propagated
to the end users?  That is, instead of

>>>                    "\\.tix$", -- Haskell Program Coverage

something like

>>>                    "# Haskell Program Coverage",
>>>                    "\\.tix$",

This makes it easier for users who need to edit .boring (because it's
guessing wrong) to make informed decisions about how to
add/remove/modify the entries.

> Anyway, the old pattern "\\.setup-config^dist(/|$)" is definitely wrong. At
> least we should change it to "\\.setup-config".

Agreed.