[darcs-users] darcs patch: resolve issue1131

David Roundy droundy at darcs.net
Thu Oct 9 12:36:02 UTC 2008


On Thu, Oct 9, 2008 at 6:45 AM, Dmitry Kurochkin
<dmitry.kurochkin at gmail.com> wrote:
>> Before we mapped from a URL to the FilePath it should be saved as when
>> downloaded.  Now we map to that and a list of possible FilePaths in
>> case we ask for it with different local names.  (We still don't know
>> why it would do this yet).  In principle, I suppose we could just
>> replace FilePath, [FilePath] by [FilePath]
>
> I wanted to put it into a single list first. But in this case we have to:
> 1. original file is first, append extra files to tail.
> 2. original file is last, append extra files to head.
>
> I did not want to append from tail or keep original file last. So I
> decided to store original file separately, afterall it is treated
> specially.

Also, the way you implemented it, we cannot run into  bugs where the
list of file names is empty, which is very, very nice.  It's a little
less compact than using a single list, but avoiding the  possibility
of  bugs is nicer.

David


More information about the darcs-users mailing list