[darcs-users] darcs patch: add tests for issue1139. (and 1 more)

Dmitry Kurochkin dmitry.kurochkin at gmail.com
Sat Oct 11 17:14:21 UTC 2008


On Sat, Oct 11, 2008 at 8:56 PM, David Roundy <droundy at darcs.net> wrote:
> Hi all,
>
> This is an alternative to Dmitry's fix for issue 1139 (together with a
> test).  My fix is more code, but preserves the idea of keeping a separate
> case for when we're diffing the entire repository (as opposed to just some
> of the files or directories).  I think this is a valuable optimization, but
> am hoping for comments, as Dmitry's code is more compact.

I like this one more than mine.

Regards,
  Dmitry

>
> David (who broke this in the first place)
>
> Sat Oct 11 11:53:24 EDT 2008  David Roundy <droundy at darcs.net>
>  * add tests for issue1139.
>
> Sat Oct 11 12:10:59 EDT 2008  David Roundy <droundy at darcs.net>
>  * resolve issue1139: make special cases handle no arguments gracefully.
>  I accidentally broke this when refactoring Darcs.Match.  This change
>  restores some efficiency when no arguments are given and thus we are
>  creating copies of all the files in the repository.
>
>
> _______________________________________________
> darcs-users mailing list
> darcs-users at darcs.net
> http://lists.osuosl.org/mailman/listinfo/darcs-users
>
>


More information about the darcs-users mailing list