[darcs-users] [kili at outback.escape.de: Re: test suite failures on OpenBSD]

David Roundy droundy at darcs.net
Mon Oct 13 12:24:11 UTC 2008


On Mon, Oct 13, 2008 at 12:08:48AM +0100, Eric Kow wrote:
> Sun Oct 12 14:30:17 CEST 2008  Matthias Kilian <kili at outback.escape.de>
>   * Remove bashisms and GNUisms
>   
>   Replace some bashisms and GNUisms by more standards compliant command
>   lines, i.e.:
>   
>   - Don't use `\|' in BREs, since it's undefined according to POSIX.
>     Instead just use grep -E with an ERE.
>   
>   - Don't create "funny" strings with the $'\x01...' bashism but use
>     printf(1) instead. Note that this isn't strictly necessary to fix
>     printer.sh on non-GNUish systems, but it makes it much simpler to test
>     what's going on.
>   
>   - In test_line(), just use grep -F, and unescape all second arguments
>     passed to test_line(). This makes the script much more readable and
>     actually fixes it for non-GNUish systems.

Applied, thanks!

And please, do keep in mind, everyone, that there's no need to eliminate
bashisms, as our tests are run with bash.  Removing gnuisms from the use of
grep and sed, on the other hand, is definitely a good idea.

David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.osuosl.org/pipermail/darcs-users/attachments/20081013/fa6477da/attachment.pgp 


More information about the darcs-users mailing list