[darcs-users] darcs patch: remove --run-posthook and --run-prehook flags (and --p...

David Roundy droundy at darcs.net
Tue Oct 14 17:09:55 UTC 2008


Hi all,

Here's an amended refactor of my previous pre/post-hook change.  I'm
still hoping for comments from someone other than Jason.  Not that I
don't appreciate Jason's comments, but given that we disagree it seems
like a good idea to get more feedback from *someone*.

This refactor doesn't change any behavior.  The old code had several
redundant checks which I removed.  It also had duplicated code between
the pre and post hooks, which I've removed.

David

Tue Oct 14 13:07:10 EDT 2008  David Roundy <droundy at darcs.net>
  * remove --run-posthook and --run-prehook flags (and --prompt-same)
  This feature has never had a safety application that I've been able to
  discern (I don't consider it *ever* safe to allow attackers to run
  darcs).  This change simplifies the code of darcs, and its use.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: text/x-darcs-patch
Size: 32885 bytes
Desc: A darcs patch for your repository!
Url : http://lists.osuosl.org/pipermail/darcs-users/attachments/20081014/c502e7da/attachment-0001.bin 


More information about the darcs-users mailing list