[darcs-users] Fwd: GHC 6.10 compatibility patches

David Roundy daveroundy at gmail.com
Fri Oct 17 17:30:13 UTC 2008


Ooops, I forgot to send this to the list...

---------- Forwarded message ----------
From: David Roundy <daveroundy at gmail.com>
Date: Fri, Oct 17, 2008 at 1:26 PM
Subject: Re: [darcs-users] GHC 6.10 compatibility patches
To: "J. Garrett Morris" <jgmorris at cecs.pdx.edu>


On Fri, Oct 17, 2008 at 1:09 PM, J. Garrett Morris
<jgmorris at cecs.pdx.edu> wrote:
> On Fri, Oct 17, 2008 at 9:50 AM, David Roundy <droundy at darcs.net> wrote:
>> The second patch, however, removing the import of system from
>> src/Exec.lhs seems very, very odd.  It certainly causes the compile to
>> fail for me, and I don't see how it could work for you with this
>> patch, since system is definitely used in this file.  Do you have an
>> explanation for this? Does it really compile for you with the patch
>> you sent?
>
> I hadn't noticed this before, but the version of System.Process
> shipped with GHC 6.10 on Windows includes the 'system' function.

Ah, that's the problem! I had looked for a module without an import
list, but somehow failed to notice it.

So the right solution would be to use a proper import that limits
itself to the functions we want from that module.

If you'd like to do this, that would be great, otherwise I'll do it
when I have time.  The basic procedure is to change the import
statement to

import System.Process ( )

and then see what is missing, and add it to the import list, and keep
repeating until everything compiles.  (This illustrates why we never
should be using these unrestricted imports:  it makes us very
sensitive to API changes...)

David


More information about the darcs-users mailing list