[darcs-users] darcs patch: extend get_sendmail_cmd to search for 'sendmail' pref ...

Christian Kellermann Christian.Kellermann at nefkom.net
Wed Oct 22 14:49:30 UTC 2008


* Christian Kellermann <Christian.Kellermann at nefkom.net> [081022 16:47]:
> > However, there's another issue that I just noticed, which is your use
> > of get_preflist and get_global.  I'd rather not use that function, as
> > it means that we're adding two more config files, which would also
> > need to be documented, which would be _darcs/prefs/sendmail and
> > .darcs/sendmail.  Too many ways to configure the same feature is just
> > confusing, as it means that a user whose sendmail is broken has that
> > many more places to look for something that's perhaps affecting the
> > behavior.  It's also more to document.  So your code will be both
> > simpler and nicer if you just use maybeGetEnv alone...
> 
> I have got that idea from the get_author function, maybe that one
> should get an overhaul as well then?

Forget this part, I need coffee....

-- 
You may use my gpg key for replies:
pub  1024D/47F79788 2005/02/02 Christian Kellermann (C-Keen)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
Url : http://lists.osuosl.org/pipermail/darcs-users/attachments/20081022/fdb1b3c8/attachment-0001.pgp 


More information about the darcs-users mailing list