[darcs-users] MODULES_FOO in makefile -- stale or clever?

Trent W. Buck trentbuck at gmail.com
Thu Oct 23 03:21:46 UTC 2008


Near the top of GNUmakefile are a whole bunch of MODULE_FOO declarations
which are only used by the DARCS_FILES declaration.

I was going to replace the whole lot with

DARCS_FILES := $(shell find src -name '[A-Z]*.lhs' -o -name '[A-Z]*.hs')

...but I discovered that find includes several extra files that weren't
in the hard-coded list.  The question is: are these files omitted from
the existing list for a reason, or is it just that someone added those
files and forgot to update the makefile?

    --- byhand	2008-10-23 14:12:41.000000000 +1100
    +++ byfind	2008-10-23 14:14:05.000000000 +1100
    @@ -64,6 +64,7 @@
     src/Darcs/Patch.lhs
     src/Darcs/Patch/Apply.lhs
     src/Darcs/Patch/Bundle.lhs
    +src/Darcs/Patch/Check.lhs
     src/Darcs/Patch/Choices.lhs
     src/Darcs/Patch/Commute.lhs
     src/Darcs/Patch/Core.lhs
    @@ -76,12 +77,16 @@
     src/Darcs/Patch/Patchy.lhs
     src/Darcs/Patch/Permutations.lhs
     src/Darcs/Patch/Prim.lhs
    +src/Darcs/Patch/Properties.lhs
    +src/Darcs/Patch/QuickCheck.lhs
     src/Darcs/Patch/Read.lhs
     src/Darcs/Patch/ReadMonads.hs
     src/Darcs/Patch/Real.lhs
     src/Darcs/Patch/Set.lhs
     src/Darcs/Patch/Show.lhs
    +src/Darcs/Patch/Test.lhs
     src/Darcs/Patch/TouchesFiles.lhs
    +src/Darcs/Patch/Unit.lhs
     src/Darcs/Patch/Viewing.lhs
     src/Darcs/Population.lhs
     src/Darcs/PopulationData.lhs
    @@ -115,6 +120,7 @@
     src/Darcs/URL.hs
     src/Darcs/Utils.lhs
     src/DateMatcher.lhs
    +src/DateTester.lhs
     src/English.lhs
     src/Exec.lhs
     src/FastPackedString.hs
    @@ -132,3 +138,5 @@
     src/UTF8.lhs
     src/UglyFileName.lhs
     src/Workaround.hs
    +src/win32/CtrlC.hs
    +src/win32/System/Posix.hs



More information about the darcs-users mailing list