[darcs-users] darcs patch: Replace just_dir with System.FilePath.ta... (and 1 more)
daveroundy at gmail.com
Mon Oct 27 17:13:40 UTC 2008
On Thu, Oct 23, 2008 at 6:09 PM, Eric Kow <kowey at darcs.net> wrote:
> On Thu, Oct 23, 2008 at 21:59:54 +0100, Eric Kow wrote:
>> On Thu, Oct 23, 2008 at 16:54:21 -0400, David Roundy wrote:
>> > Although I think I'd be more comfortable using System.FilePath.Posix,
>> > just so we maintain the same behavior. Is there any reason to use
>> > System.FilePath?
>> Hmm... none that I can really think of, unless you would consider
>> the ability to replace Workaround.getCurrentDirectory by just
>> plain old System.Directory.getCurrentDirectory as a reason.
> Oh another reason would be to avoid confusing people reading the code
> (if we aren't seriously expecting System.FilePath.Posix, we might as
> well avoid specifically importing that so that future people reading
> the code don't have to ask themselves "why Posix?")
I would like people who read the code to be able to learn about its
invariants in doing so, and I would suggest that using
System.FilePath.Posix would correctly convey the fact that these paths
are delimited by "/".
More information about the darcs-users