[darcs-users] darcs patch: Add -[-no]-http-pipelining options, disable pipelining...

Jason Dagit dagit at codersbase.com
Mon Sep 8 18:11:55 UTC 2008


On Mon, Sep 8, 2008 at 11:02 AM, Dmitry Kurochkin
<dmitry.kurochkin at gmail.com> wrote:
> Mon Sep  8 21:57:26 MSD 2008  Dmitry Kurochkin <dmitry.kurochkin at gmail.com>
>  * Add -[-no]-http-pipelining options, disable pipelining by default for curl < 7.19.1.

I can't comment on the technical aspects, but it seems like there has
been quite a bit of back and forth already about when and where to
disable pipelining so I will trust others have checked those details.

The one thing I would comment is that I prefer to not use Bool to
toggle things usually, although given that the option is purely binary
maybe setPipelining is okay to use a bool parameter.

Overall, the patch looks nice and clean.

Thanks!
Jason


More information about the darcs-users mailing list