[darcs-users] darcs patch: fix bug in file path handling. (and 2 more)

[Eric Kow]

Thanks!

> Since we cleanup paths in some places, we should store clean and
> unclean paths in different types so that the type system can tell us
> which is expected where.

I think FileName and the various RepoPath types correspond to CleanPath
whereas and FilePath corresponds to RawPath.

Did you mean something else?

> We could go a step further and manipulate paths as lists that we join
> back together with the proper separator when it's time to use the
> path.

This is John Meachem's idea, I think, which I have bounced to this list.
He even sent some code.

> What does (/-) do?

See my review [ which could be wrong, of course ;-) ]
 
> More haddocks would be nice too.

Yes! Especially for this module, where examples tell you a lot of what
you need to know.

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.osuosl.org/pipermail/darcs-users/attachments/20080910/246c12f3/attachment.pgp