[darcs-users] darcs patch: remove buggy unused function combine. (and 1 more)

Eric Kow kowey at darcs.net
Thu Sep 11 08:16:08 UTC 2008


Looks good to me.

I was never really very comfortable with withInternal, so if we can get
rid of it, fine.

remove buggy unused function combine.
-------------------------------------
> -combine :: FilePathLike a => a -> SubPath -> a
> -combine p1 (SubPath "") = p1
> -combine p1 (SubPath p2) | null (toInternal p1) = fromFilePath p2
> -combine p1 (SubPath p2) = withInternal (++ '/':p2) p1

remove ugly unused function appendToPath.
-----------------------------------------
> -appendToPath :: FilePathLike a => String -> a -> a
> -appendToPath suf = withInternal (++ suf)

> -withInternal :: FilePathLike a => (FilePath -> FilePath) -> a -> a
> -withInternal f = fromFilePath . f . toInternal

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
Url : http://lists.osuosl.org/pipermail/darcs-users/attachments/20080911/39635651/attachment.pgp 


More information about the darcs-users mailing list