[darcs-users] darcs patch: Spaces and punctuation in upload.cgi. (and 1 more)

David Roundy droundy at darcs.net
Sat Sep 13 11:45:28 UTC 2008


On Fri, Sep 12, 2008 at 04:32:08PM -0700, Dmitry Kurochkin wrote:
> Hi.
> 
> Here are patches for upload.cgi to support patch checking and sending with
> sendmail. It has a set of parameters like sendmail command, test repo, test
> command. At the moment all parameters are hardcoded in the script.
> 
> For darcs to send patches through POST there should be a 'post' file in prefs.
> That file can contain http URLs and mailto: addresses. At the moment if post
> file exists emails file is not read. So this 'mailto:' functionality seems
> like replacing email file to me. I think we should remove it. In this case
> email file contains emails and post file contains URLs.
> 
> Another issue is that darcs always sends patches through both email and
> POST. I think we should try POST first and send through email only if it fails.
> Or we can use 'mailto:' lines from post file to form To: header for POSTed
> email, and email file for addresses we really send mail to directly.
> 
> I am not a good Perl coder, so it would be nice if someone reviews the changes.

Applied.  Thanks!

David


More information about the darcs-users mailing list