[darcs-users] darcs patch: Re-enable haskeline by default (and 1 more)

David Roundy droundy at darcs.net
Wed Sep 17 21:10:25 UTC 2008


On Wed, Sep 17, 2008 at 12:50:52PM -0700, Judah Jacobson wrote:
> On Wed, Sep 17, 2008 at 11:47 AM, David Roundy <droundy at darcs.net> wrote:
> > On Wed, Sep 17, 2008 at 11:24:14AM -0700, Judah Jacobson wrote:
> >> I have just released haskeline-0.3 which (among other things) fixes
> >> the bugs reported in issue1050.  I confirmed that 'make test' passes
> >> with haskeline enabled, so I humbly suggest that haskeline be
> >> re-enabled by default in 2.0.3.
> >
> > It would be much better to change the configure test to fail on
> > versions of haskeline older than 0.3.  This is easy to do if you made
> > any API change in this release.
> 
> Sounds reasonable.  There weren't any API changes in 0.3, so I made a
> small addition and released haskeline-0.3.1.  See attached (I'm
> resending the EOF/EOT patch unmodified from before).

Looks good to me, thanks! Applied.  I hope this API addition wasn't
purely gratuitous!

> Wed Sep 17 11:01:24 PDT 2008  Judah Jacobson <judah.jacobson at gmail.com>
>   * Throw an error when haskeline returns an EOF/EOT.

One note.  This patch adds some trailing whitespace.  It's nicer not
to do this.  I'm trusting you that this behavior is appropriate,
having only vaguely followed your discussion on this particular
change.

> Wed Sep 17 12:40:07 PDT 2008  Judah Jacobson <judah.jacobson at gmail.com>
>   * Re-enable haskeline by default.  Require haskeline>=0.3.1 which
> fixes issue1050.


More information about the darcs-users mailing list