[darcs-users] darcs patch: make flagsToPristine obey repository for... (and 1 more)

[Eric Kow]

On Wed, Sep 24, 2008 at 11:48:38 -0400, David Roundy wrote:
> >     where flags2inv | UseOldFashionedInventory `elem` fs = [Darcs1_0]
> >                     | otherwise = [HashedInventory]
> 
> No, this fails if --hashed and --darcs-2 are both provided.  I'd
> rather have this be robust, since darcs-2 requires HashedInventory.

Gotcha... athough I think you meant if --old-fashioned and --darcs-2 are
both provided.

> >     where flags2inv | UseFormat2 `elem` fs = [HashedInventory]
> >                     | UseHashedInventory `elem` fs = [HashedInventory]
> >                     | UseOldFashionedInventory `elem` fs = [Darcs1_0]
> >                     | otherwise = flags2inv [HashedInventory]
> >
> > Which could simplify switching to some hypothetical inventory format...
> > or maybe I'm just in YAGNI-land
> 
> This seems like needless overkill.

Yeah.

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.osuosl.org/pipermail/darcs-users/attachments/20080924/e1491992/attachment.pgp