[darcs-users] darcs patch: Make FileName.drop_dotdot work with abso... (and 2 more)
Simon Michael
simon at joyful.com
Thu Sep 25 19:06:43 UTC 2008
Hi Dmitry,
thanks for this patch; I confirm it fixes issue 1078 on mac and on
gnu/linux.
This area of the code is hard to follow if you're not intimately
familiar with all functions involved, I didn't follow the logic in
perfect detail. I did wonder if it's still necessary to handle the isdir
case as a separate case in ioAbsolute.
I vote +1 to apply, unless..
> Is there any reason not to use System.Directory.canonicalizePath in
> ioAbsolute? It seems to do just what we need.
None that I know of, if it's portable as advertised. I guess that would
greatly simplify and clarify this code, so a new patch using this would
be even better.
Best
-Simon
More information about the darcs-users
mailing list