[darcs-users] darcs patch: fix memory leak in check/repair

[Eric Kow]

Hi Bertram,

On Wed, Apr 22, 2009 at 19:33:42 +0200, Bertram Felgenhauer wrote:
> E.Y.Kow wrote:
> > Sat Mar 21 04:22:37 GMT 2009  David Roundy <droundy at darcs.net>
> >   * fix memory leak in check/repair
> 
> I think I understand what this patch does now, and its relation to
> Petr's and my patches,

Woo! I must say that this review has pretty much everything:
 - the wider context
 - the low-level details
 - explanation of what makes the patch tick
 - actual numbers (!) useful when dealing with performance patches
 - crucially, interactions with the rest of the code
 - and the take-home message

Sorry for the burst of enthusiasm :-)

> This refactors 'write_and_read_patch' and adds an 'unsafeInterLeaveIO'
> around the call to 'createHashed'.

Does this call for any sort of documentation anywhere?

> So David's patch has little effect now. It can coexist peacefully with
> Petr's and my changes though, and improving makePatchLazy seems to be
> a good idea - I think it should be applied.

Applied, thanks!

Cheers,

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.osuosl.org/pipermail/darcs-users/attachments/20090422/f19bf8b8/attachment.pgp>