[darcs-users] darcs patch: Minor refactor in Darcs.Arguments. (and 4 more)

[Dmitry Kurochkin]

On Thu, Apr 23, 2009 at 2:52 PM, Eric Kow <eric.kow at gmail.com> wrote:
> On Tue, Apr 21, 2009 at 00:02:43 +0400, Dmitry Kurochkin wrote:
>> All look good. Only question is on maxCount reexport. Is it a good
>> style? Should we move maxCount to Darcs.Arguments perhaps?
>
> Thanks!  I've pushed this bundle and added a patch to move this around
>
>> Good laziness example :) As I understand naive implementation was not
>> lazy because it had to go through all patches anyway to compute other
>> arguments of the tuple?
>
> That sounds right.  I don't have a very good grasp of laziness, though,
> so little lessons like these are helpful to me.

Actually, I think your naive implementation would be lazy now, when
(-:-) is fixed.

But it is wrong from another point - filter_patches_by_names can
return error. And if max-count is outside filter_patches_by_names we
can get errors for unrelated patches.

Regards,
  Dmitry

>
> --
> Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
> PGP Key ID: 08AC04F9
>