[darcs-users] darcs patch: change parseData in OldDate and IsoDate to use ByteStr...

[Trent W. Buck]

Eric Kow <kowey at darcs.net> writes:

> On Fri, Apr 24, 2009 at 01:38:57 -0700, Benedikt Schmidt wrote:
>> Fri Apr 24 10:33:17 CEST 2009  Benedikt Schmidt <beschmi at gmail.com>
>>   * change parseData in OldDate and IsoDate to use ByteStrings
>>   
>>   This is a performance optimization to speed up patch
>>   parsing and make_filename. The old version used naive
>>   list code to parse the date (drop, take, and read). Just
>>   using the more efficient ByteString versions makes the code
>>   fast enough to not be a bottleneck.
>  
> Applied, thanks!
>
> We try to be very careful about modifying the 'Old' modules because
> we're afraid of breaking backward compatibility with older patches.

Are there already unit tests for these date parsing functions?  If we
want to be paranoid about a particular module, one way to express this
paranoia concretely is to ensure there are a lot of unit tests for it.