[darcs-users] darcs patch: change parseData in OldDate and IsoDate to use ByteStr...

[Eric Kow]

On Sat, Apr 25, 2009 at 12:18:27 +1000, Trent W. Buck wrote:
> Are there already unit tests for these date parsing functions?  If we
> want to be paranoid about a particular module, one way to express this
> paranoia concretely is to ensure there are a lot of unit tests for it.

I think there are only some detailed regressions tests.  The main issue
with the dates code (which wasn't particularly relevant for this patch)
is that we don't have a clear picture what we actually expect it to do.

I bet can do a lot to simplify OldDate, if we were willing to do some
archeology and get a clear picture what kinds of date strings older
versions of darcs produced in their patch files, i.e. what kinds of
things we are expected to parse.  I'm pretty sure, for example, that we
can rip out the English date parsing code with no ill effect.  I tried
once, but then I made the mistake of going too far.  Doesn't mean we
shouldn't try again, just more carefully and with more research to back
it up.

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.osuosl.org/pipermail/darcs-users/attachments/20090427/e6123477/attachment.pgp>