[darcs-users] [patch120] move witness support into its own namespace
Eric Kow
bugs at darcs.net
Thu Dec 24 10:33:56 UTC 2009
Eric Kow <kowey at darcs.net> added the comment:
On Sat, Dec 19, 2009 at 23:01:03 +0000, Ganesh Sittampalam wrote:
> I think it would be good to have all the witness support code in
> a specific namespace.
>
> Really annoyingly, the replace patches here don't commute/merge with most
> other replace patches, because they have '.'s in the regexp to support
> the renaming of Darcs.Ordered -> Darcs.Witnesses.Ordered etc, and
> replace patches with different regexps never commute.
So aside from the commute problems, one of the entries in our
GettingStarted guide (I think I wrote this after our experiences merging
in some replace patches) was
Try to avoid using the tokens . and - in your darcs replace patches
that affect Haskell files. The problem is that the . can affect code
like lines.liftM
Now I don't really remember why this would be an issue in practice.
Anyway, as for the commute problem, the Darcs manual suggests that as a
best practise, each project should standardise on its own set of tokens
to avoid the commute problem (or at least it used to).
Do we you think we should follow that advice and just darcs replace for
things we can do with (say) the default tokens?
Eric, who has submitted his fair share of weird darcs replace patches.
--
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
----------
nosy: +kowey
__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch120>
__________________________________
More information about the darcs-users
mailing list