[darcs-users] darcs patch: Make Haskeline a required dependency (+ 4 more)

[Eric Kow]

First of all: anybody have objections to this in principle?

I generally support the idea that we need to reduce the number of code
paths for easier maintainability (e.g. number of ways to fetch a file
over HTTP).  Since this looks a generally non-risky area, I think it
makes sense to just go for it (no sunsets here), provided it passes
review.

Second: Salvatore, do you think you would be available to review this
bundle?

On Tue, Feb 03, 2009 at 09:15:44 -0800, Judah Jacobson wrote:
> The attached patches address two issues:
> 
> 1) Fix some small problems when building with Cabal on Windows.
> 
> 2) Make Haskeline required instead of optional.  This removes a
> significant amount of platform-dependent terminal manipulation, so I
> think it's worth considering.
> 
> The Haskeline changes have been tested on both OS X and Windows; I
> split it into two patches since the second ("Don't set stdin's
> buffering") should probably be reviewed by someone more familiar than
> me with SelectChanges.hs.
> 
> Once this is applied, developers may need to use "cabal update &&
> cabal install haskeline" to get a recent enough version of Haskeline.
> 
> 
> Mon Feb  2 18:34:00 Pacific Standard Time 2009  Judah Jacobson
> <judah.jacobson at gmail.com>
>   * Make Haskeline a required dependency.
> 
>     M ./configure.ac -13 +2
>     M ./darcs.cabal -13 +4
>     M ./src/Darcs/Utils.hs -42 +13
> 
> Mon Feb  2 19:06:26 Pacific Standard Time 2009  Judah Jacobson
> <judah.jacobson at gmail.com>
>   * Don't set stdin's buffering; Haskeline will do that for us.
> 
>     M ./src/Darcs/SelectChanges.hs -12 +8
>     M ./src/Darcs/Utils.hs -80 +4
> 
> Tue Feb  3 08:48:24 Pacific Standard Time 2009  Judah Jacobson
> <judah.jacobson at gmail.com>
>   * Don't use the bytestring-mmap package on Windows.
> 
>     M ./darcs.cabal -2 +2
> 
> Tue Feb  3 08:52:06 Pacific Standard Time 2009  Judah Jacobson
> <judah.jacobson at gmail.com>
>   * Tell Cabal about send_email.c on Windows.
> 
>     M ./darcs.cabal +1
> 
> Tue Feb  3 08:52:58 Pacific Standard Time 2009  Judah Jacobson
> <judah.jacobson at gmail.com>
>   * Remove a redundant clause from the Cabal file."
> 
>     M ./darcs.cabal -8


> _______________________________________________
> darcs-users mailing list
> darcs-users at darcs.net
> http://lists.osuosl.org/mailman/listinfo/darcs-users


-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
Url : http://lists.osuosl.org/pipermail/darcs-users/attachments/20090203/d9e718e7/attachment.pgp