[darcs-users] darcs patch: Replace Autoconf.hs with consistent use of CPP.

Trent W. Buck trentbuck at gmail.com
Thu Feb 19 15:16:33 UTC 2009


Thanks for the review!

On Thu, Feb 19, 2009 at 03:17:23PM +0100, Petr Rockai wrote:
> > +#ifdef have_HTTP
> Should this be HAVE_HTTP instead of have_HTTP?

Nice catch.

> > +speculateRemote u _ = maybeURLCmd "GET" u >> return ()
> Same as maybeURLCmd "GET" u (without >> return()).

Cool, I'll patch that.

> >  norm_slashes :: String -> String
> > hunk ./src/SHA1.hs 18
> >  -- the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
> >  -- Boston, MA 02110-1301, USA.
> >  
> > -{-# OPTIONS_GHC -fno-warn-name-shadowing #-}
> > +{-# OPTIONS_GHC -fno-warn-name-shadowing -cpp #-}
> > +{-# LANGUAGE CPP #-}
> Did we miss those in other places? (I guess no if it compiles for you...)

This was the only file that didn't already mention CPP in this manner, but
I admit I don't understand this bit fully.


More information about the darcs-users mailing list