[darcs-users] darcs patch: Refactor add_to_list.
Petr Rockai
me at mornfall.net
Wed Jan 21 06:58:09 UTC 2009
"Trent W. Buck" <trentbuck at gmail.com> writes:
>> The net effect of the ordering change is that when you pull from a completely
>> new repository, it will be added as a first item to _darcs/prefs/repos instead
>> of last. The function doesn't seem to be used for _darcs/prefs/sources, where
>> ordering *does* matter (*but* current darcs gets it wrong anyway, so...).
>
> Thanks, Petr. Do you think this patch should be applied as-is, or
> should I amend it to avoid the reversal?
I'd vote for a patch removing add_to_list altogether and using Data.List.union
in its place. Otherwise, I have no preference -- reversal is fine with me.
Yours,
Petr.
--
Peter Rockai | me()mornfall!net | prockai()redhat!com
http://blog.mornfall.net | http://web.mornfall.net
"In My Egotistical Opinion, most people's C programs should be
indented six feet downward and covered with dirt."
-- Blair P. Houghton on the subject of C program indentation
More information about the darcs-users
mailing list