[darcs-users] darcs patch: Roll back the getSymbolicLinkStatus work... (and 3 more)

Eric Kow kowey at darcs.net
Tue Jul 21 18:59:30 UTC 2009


On Fri, Jul 17, 2009 at 18:17:59 +0200, Petr Rockai wrote:
> there appear to be some outstanding patches in my local branch. I may have sent
> some of them before and they may have fallen through the cracks. Or not.

Applied, thanks!

Roll back the getSymbolicLinkStatus workaround, since it constitutes a fd leak.
Use tee in pending_has_conflicts.sh for easier debugging.
---------------------------------------------------------
No comment.

Slightly refactor test machinery in Setup.lhs.
----------------------------------------------
> Petr Rockai <me at mornfall.net>**20090714134119
>  Ignore-this: 32206a331658d407d9c0fb3b48405db6
> ] hunk ./Setup.lhs 286
>      createDirectory ".darcs"
>      when (not $ null fmt) $ appendFile ".darcs/defaults" $ "ALL " ++ fmt ++ "\n"
>      putStrLn $ "Running tests for format: " ++ fmt
> -    exec
> - where exec = do
> -         fs <- case tests of
> -                  [] -> sort `fmap` getDirectoryContents "."
> -                  x -> return x
> -         cwd <- getCurrentDirectory
> -         let run = filter isTest fs
> -         res <- Harness.runTests (Just darcs_path) cwd run
> -         when ((not res) && (k /= Bug)) $ fail "Tests failed"
> -         return ()

I wonder what the intention behind this original helper function was.

Slightly refactor the run function in ShellHarness.
---------------------------------------------------
No comment, straightforward refactor.

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.osuosl.org/pipermail/darcs-users/attachments/20090721/5a5263f4/attachment.pgp>


More information about the darcs-users mailing list