[darcs-users] darcs patch: Make utf8-string mandatory. (and 1 more)
ganesh at earth.li
Wed Jul 22 21:25:25 UTC 2009
On Wed, 22 Jul 2009, Eric Kow wrote:
> Hi Ganesh,
> On Wed, Jul 22, 2009 at 11:24:35 +0200, Petr Rockai wrote:
>> while we are in a cleanup mode, let's also get rid of the bad ugly custom zlib
> Any comments? I think you advised a more deliberate approach with the
> zlib stuff at the hackathon, which my natural inclination is to agree
> I'm personally happy with leaving the old zlib stuff in there until
> 2.5 (not built by default). On the other hand, I recognise that my
> style of dragging things out in the name of conservatism/carefulness
> leads to a lot of undue pain. If you neither of you can convince the
> other, I think I'm willing to try it Petr's way.
Downside of removing it: unexpected problem with Haskell zlib means we
need to revert in a hurry. It's happened before :-)
I accept that getting rid of cruft is a worthwhile end in itself with
general knock-on benefits of a simpler code base. However are there any
specific things that the old zlib is obstructing? If not, I would remain
in favour of keeping it around until either (a) the next release cycle or
(b) a better reason to remove it comes along.
I don't feel strongly enough to make a lot of noise about this, though.
More information about the darcs-users