[darcs-users] darcs patch: Remove support for calling wget/curl on ... (and 2 more)

Petr Rockai me at mornfall.net
Sun Mar 15 13:19:33 UTC 2009


Hi,

trentbuck at gmail.com (Trent W. Buck) writes:
> I feel that if this is done, at compile time Darcs must insist on finding at
> least one HTTP client library.

In theory, these two hunks should address that:

from patch by Eric Kow:
> hunk ./darcs.cabal 352
>          pkgconfig-depends: libcurl >= 7.19.1
>        cpp-options:       -DCURL_PIPELINING -DCURL_PIPELINING_DEFAULT
>  
> -  else
> -    if flag(http)
> +  if flag(http) || !flag(curl)
>        build-depends:    network == 2.2.*,
>                          HTTP    >= 3000.0 && < 3001.1
>        cpp-options:      -DHAVE_HTTP
> hunk ./darcs.cabal 478
>          pkgconfig-depends: libcurl >= 7.19.1
>        cpp-options:       -DCURL_PIPELINING -DCURL_PIPELINING_DEFAULT
-  else
-    if flag(http)
+   if flag(http) || !flag(curl)
       build-depends:    network == 2.2.*,
                         HTTP    >= 3000.0 && < 3001.1
       cpp-options:      -DHAVE_HTTP

Although it might be cleaner to express that with something like

if !flag(http) && !flag(curl)
    buildable: False

instead of dragging in that "|| !flag(curl)".

Yours,
   Petr.

-- 
Peter Rockai | me()mornfall!net | prockai()redhat!com
 http://blog.mornfall.net | http://web.mornfall.net

"In My Egotistical Opinion, most people's C programs should be
 indented six feet downward and covered with dirt."
     -- Blair P. Houghton on the subject of C program indentation


More information about the darcs-users mailing list