[darcs-users] darcs patch: make rollback smarter about breaking up ... (and 5 more)

Reinier Lamers tux_rocker at reinier.de
Tue Mar 17 20:38:18 UTC 2009


Hi,

> > > clean up Depends a wee tad
> > > --------------------------
> > > -                 Left e -> throwError (MissingPatch (info hp) e)
> > > +                 Left e -> Left (MissingPatch (info hp) e)
> >
> > Does this make the code more obscure?  I don't know how strong the
> > association of Left with "this is an error" is within the Haskell
> > community, but to me the change looks to make things harder to
> > understand merely to avoid importing one extra thingy.
>
> I can't speak for the Haskell community, but it's pretty strong to me,
> using the Left e for the error condition and the Right for the successful
> one.

Also strong for me. I'd say its more Haskell-like than exceptions, they are 
impure in a way.

Reinier
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.osuosl.org/pipermail/darcs-users/attachments/20090317/065d7e77/attachment.pgp>


More information about the darcs-users mailing list