[darcs-users] darcs patch: make rollback smarter about breaking up ... (and 5 more)

Trent W. Buck trentbuck at gmail.com
Tue Mar 17 23:10:23 UTC 2009


On Tue, Mar 17, 2009 at 09:38:18PM +0100, Reinier Lamers wrote:
> Hi,
> 
> > > > clean up Depends a wee tad
> > > > --------------------------
> > > > -                 Left e -> throwError (MissingPatch (info hp) e)
> > > > +                 Left e -> Left (MissingPatch (info hp) e)
> > >
> > > Does this make the code more obscure?  I don't know how strong the
> > > association of Left with "this is an error" is within the Haskell
> > > community, but to me the change looks to make things harder to
> > > understand merely to avoid importing one extra thingy.
> >
> > I can't speak for the Haskell community, but it's pretty strong to me,
> > using the Left e for the error condition and the Right for the successful
> > one.
> 
> Also strong for me. I'd say its more Haskell-like than exceptions, they are 
> impure in a way.

OK, then I rescind my reservations about this patch.


More information about the darcs-users mailing list