[darcs-users] darcs patch: Resolve issue1351: fix repository path handling on Windows (and 1 more).
Eric Kow
kowey at darcs.net
Sun May 10 01:47:29 UTC 2009
On Sat, May 09, 2009 at 21:19:48 +0200, Salvatore Insalaco wrote:
> Windows path handling is still not optimal, but to fix it we should
> probably make bold choices (like stopping to convert everyting to
> "posix-like" format, as some kind of Windows path have no Posix
> equivalent); this patch at least avoid an infinite loop inside darcs.
Sigh :-)
Hopefully we can one day spin off our RepoPath and our path-fixing
code to be a standalone module.
> Sat May 9 20:36:06 CEST 2009 Salvatore Insalaco <kirby81 at gmail.com>
> * Resolve issue1351: fix repository path handling on Windows.
>
> ioAbsolute is supposing that takeDirectory will eventually lead to
> an existing directory. This is true on Posix, where it will lead to
> "/", but not on Windows, where it could lead to a non-existing unit or
> an UNC reference to a non-existing server.
> This patch fixes this assumption, avoiding an infinite recursion.
This looks good to me.
Could I be annoying and ask you to amend --edit that patch, wrapping
that description at 72 characters?
> Sat May 9 20:57:02 CEST 2009 Salvatore Insalaco <kirby81 at gmail.com>
> * Remove unused function: Darcs.Patch.Prim.applyBinary
I've applied this one, thanks!
--
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-users/attachments/20090509/eb26e0dc/attachment-0001.pgp>
More information about the darcs-users
mailing list