[darcs-users] [patch40] build fixes for GHC 6.12

Petr Rockai me at mornfall.net
Mon Nov 2 21:25:25 UTC 2009


Hi,

Ganesh Sittampalam <ganesh at earth.li> writes:

> +newtype TreeFilter = TreeFilter { applyTreeFilter :: forall t m . FilterTree t m => t m -> t m }

> -restrictBoring :: IO (forall t m. FilterTree t m => t m -> t m)
> +restrictBoring :: IO TreeFilter
this is going to conflict with http://bugs.darcs.net/patch31 so the patch that
gets recorded later will probably needs amends.

Also, the other related changes (putting applyTreeFilter all around the place)
is going to conflict with patch16.

Other than that, the patch looks OK to me (although I'd be happier if the code
was a little less verbose about the tree filters... I actually think that
restrictBoring is, after patch31, no longer impredicative, but restrictSubpaths
still is and I'm not sure if there's an easier way around it than a newtype).

Yours,
   Petr.


More information about the darcs-users mailing list