[darcs-users] new patch status?

Trent W. Buck twb at cybersource.com.au
Wed Nov 18 01:03:55 UTC 2009


"Sittampalam, Ganesh" <ganesh.sittampalam at credit-suisse.com> writes:

> Trent W. Buck wrote:
>> Ganesh Sittampalam <ganesh at earth.li> writes:
>>> On Tue, 17 Nov 2009, Trent W. Buck wrote:
>>>> [...] patches that don't apply cleanly are automatically set to
>>>> needs-amend?
>>>
>>> I think the difficulty here is uniquely identifying the correct
>>> attached bundle to apply, once a patch has been amended or similar.
>>
>> I was assuming that this was happening as the mail came in, before it
>> got injected into roundup.  It would use the first MIME attachment of
>> type text/x-darcs-patch (or whatever "darcs send" uses).[...]
>
> But the end result of testing the patch needs to affect roundup
> somehow - I guess you are implying that it should always be the latest
> patch that controls the roundup status?

Good point; I was assuming that.  After all, each patch object (in
roundup) can only have one status, so it didn't make sense to me to send
new bundles to an existing roundup patch object, unless they were
amendments to the previous bundle in that object.

> Also, this idea doesn't work so well for doing something long-running
> or possibly unreliable like building and running the tests.

Granted.



More information about the darcs-users mailing list