[darcs-users] new patch status?

Reinier Lamers tux_rocker at reinier.de
Wed Nov 18 19:50:01 UTC 2009


Hi darcsies,

Op woensdag 18 november 2009 07:43 schreef Eric Kow:
> On Mon, Nov 16, 2009 at 22:16:04 +0000, Ganesh Sittampalam wrote:
> > I wonder if we can add a new status to the patch tracker to reflect
> > the state of "had human review, needs standard tests run"? It would
> > make it easier to do different jobs in batch mode, and it would also
> > allow different people to do the review and the actual push.
> 
> I've added an accepted-pending-tests status.
> Please expect an update on the state of the patch tracker sometime in
> the future.

Just being paranoid: doesn't this have a social security problem? Some
dude registers with the bug trackers, flips some patches
to accepted-pending-tests. Some drowsy darcs hacker with coffee withdrawal
symptoms goes to bug tracker, sees accepted-pending-tests patches, and pushes
them without checking who checked it and what their comments were. It sounds
all imaginable to me, and at that point you're sending arbitrary code to 
the buildbots.

So having the same person check the code and push it sounds safe to me. Or
restrict the right to set a patch to 'accepted-pending-tests' in roundup.

Bye,
Reinier
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.osuosl.org/pipermail/darcs-users/attachments/20091118/acc095d9/attachment.pgp>


More information about the darcs-users mailing list