[darcs-users] darcs patch: test that tentative leftover is cleared (and 2 more)

Kamil Dworakowski kamil at dworakowski.name
Wed Sep 2 23:02:31 UTC 2009

This time there are three patches to comply with the request to submit
tests separately.

I have created a new test that ensures tentative state left after an
uncommitted transaction does not affect subsequent ones. I have also
extended the test for the issue1406, more on that in a moment.

When I was submitting the original patch I didn't know what
checkpoints were. It turns out that my original patch left the
remove_from_tentative_inventory function still manipulating some real
state of the repository, namely the checkpoints inventory. I have now
changed it so that, analogous to the normal inventory, checkpoints
inventory is being manipulated tentatively. I have extended the test
for issue1406 to cover that. Now it checks that real checkpoints
inventory is not modified by a failed amend. You can't create checkpoints
with the current version of darcs, so I have created a repo with an
older version and put it in tests/repos dir.

Wed Sep  2 09:52:12 BST 2009  Kamil Dworakowski <kamil at dworakowski.name>
  * test that tentative leftover is cleared

Wed Sep  2 23:03:21 BST 2009  Kamil Dworakowski <kamil at dworakowski.name>
  * activate and extend issue1406 test
  extend with checkpoint modification checking

Wed Sep  2 23:10:53 BST 2009  Kamil Dworakowski <kamil at dworakowski.name>
  * resolve issue1406: amend-record unrecords on a test failure
  A failing test on amend no longer unrecords the original patch. The
  failure manifested itself only on old-fashioned repositories. Change
  DarcsRepo.remove_from_tentative_inventory not to modify the pristine
  nor the inventory.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: text/x-darcs-patch
Size: 90815 bytes
Desc: A darcs patch for your repository!
URL: <http://lists.osuosl.org/pipermail/darcs-users/attachments/20090903/10e130b8/attachment-0001.bin>

More information about the darcs-users mailing list