[darcs-users] darcs patch: Make the ./tests/issue1465_ortryrunning.sh a little mo...

Eric Kow kowey at darcs.net
Wed Sep 9 15:12:16 UTC 2009


On Wed, Sep 09, 2009 at 16:49:58 +0200, Petr Rockai wrote:
> this should fix the failure on Nicolas' buildslave (where I noticed
> DARCS_EDITOR leaks into the test environment, which is something we should
> cater for -- either by explicitly guarding in the tests like this patch, or by
> filtering the environment more vigorously in ShellHarness (which is probably
> somewhat more robust -- patches welcome, I suppose).

I wonder why we don't just empty out the environment altogether and just
add in bits and pieces that we need?  Blacklist => whitelist?

> Wed Sep  9 16:43:49 CEST 2009  Petr Rockai <me at mornfall.net>
>   * Make the ./tests/issue1465_ortryrunning.sh a little more foolproof.

Applied, thanks!  No comment.

Make the ./tests/issue1465_ortryrunning.sh a little more foolproof.
-------------------------------------------------------------------
> -not env -u TERM VISUAL=false </dev/null &>R/log \
> +not env -u TERM DARCS_EDITOR=false VISUAL=false </dev/null &>R/log \

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.osuosl.org/pipermail/darcs-users/attachments/20090909/b09a8a9f/attachment.pgp>


More information about the darcs-users mailing list