[darcs-users] darcs patch: make an assumption in the pull code explicit

Jason Dagit dagit at codersbase.com
Wed Sep 9 19:40:56 UTC 2009


On Wed, Sep 9, 2009 at 12:28 PM, Ganesh Sittampalam <ganesh at earth.li> wrote:

> On Wed, 9 Sep 2009, Jason Dagit wrote:
>
>  Anyway, I'm almost 100% certain we can't hit the impossible case.  I seem
>> to
>> recall that David had asked me to hold off and refactoring it simply
>> because
>> my focus was elsewhere previously (one simple change at a time).  Once the
>> type-witnesses are 100% I think we should revisit get_common_and_uncommon.
>> Actually, I feel like a lot of the Depends module needs modernization and
>> cleanup.  We still see bugs there way more regularly than we should and
>> the
>> way the algorithms are expressed there are too many unsafeCoercePs in that
>> module.
>>
>> I think I'll go make a bug ticket for this future refactor.
>>
>
> Actually I did the refactor on the train and am just cleaning it up to
> submit :-)
>

Wonderful!

I made the ticket anyway because this cleanup of get_common_and_uncommon
isn't the only work we need to do in this module.  Feel free to update the
ticket after you submit your patches:
http://bugs.darcs.net/issue1604

Jason
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osuosl.org/pipermail/darcs-users/attachments/20090909/28cc4826/attachment.htm>


More information about the darcs-users mailing list