[darcs-users] darcs patch: Simplify and camel-case setSimplys. (and 4 more)

Kamil Dworakowski kamil at dworakowski.name
Tue Sep 22 22:29:11 UTC 2009


On Mon, Sep 21, 2009 at 10:27 AM, Eric Kow <kowey at darcs.net> wrote:
> Mon Sep 21 11:10:24 CEST 2009  Eric Kow <kowey at darcs.net>
>  * Some haddocks and questions for Darcs.Patch.Choices.

+--   * Any patches found to depend on an earlier @InMiddle@ patch are
marked with
+--     'negTag'.
+--     Question (Eric Kow): why?

I think it does nothing useful. It was added initially as -1 in:

darcs diff -u -p 'Add support for gui record.'

This patch is much easier to understand than the current code. You can
see that this -1
is meaningless by analyzing the mode of usage of pull_first and pull_firsts.

Of course, over time something might have started depending on it, but
probably not.

--
Cheers,
Kamil


More information about the darcs-users mailing list