[darcs-users] darcs patch: Simplify and camel-case setSimplys. (and 4 more)

Eric Kow kowey at darcs.net
Wed Sep 23 06:48:11 UTC 2009


On Tue, Sep 22, 2009 at 23:29:11 +0100, Kamil Dworakowski wrote:
> darcs diff -u -p 'Add support for gui record.'
> 
> This patch is much easier to understand than the current code. You can
> see that this -1
> is meaningless by analyzing the mode of usage of pull_first and pull_firsts.

Also, perhaps you could elaborate on why you think this is meaningless?

It sounds like we could replace negTag with forgetTag restoring the -1
behaviour (depending on whether Ian chimes in to point out that it
actually is meaningful).

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-users/attachments/20090923/281ae3d8/attachment-0001.pgp>


More information about the darcs-users mailing list