[darcs-users] darcs patch: accept issue1620: record lies about leav... (and 1 more)

Trent W. Buck trentbuck at gmail.com
Tue Sep 29 14:46:05 UTC 2009

Jason, the test scripts look OK to apply from visual inspection.
Nitpicks follow.

> LOGFILE=`grep "Logfile left in" out | sed "s/Logfile left in //" | sed
> s/.$//`

I would use a single awk or sed command here, e.g.

    sed -n '/Logfile left in/ { s/Logfile left in //; s/\.$//; p}' out

> test -e "$LOGFILE"

Testing the $LOGFILE is a file as well (test -f) wouldn't hurt.

> grep 'new log' $LOGFILE

Likewise, grep '^new log$' or fgrep -x 'new log' would be more specific.
I'm thinking of a hypothetical case where the logfile manages to contain
an error like "bash: echo 'new log' >foo: command not found".

More information about the darcs-users mailing list