[darcs-users] darcs patch: add utility functions to Commands.lhs (and 10 more)

Jason Dagit dagit at codersbase.com
Wed Sep 30 14:16:38 UTC 2009


On Wed, Sep 30, 2009 at 6:35 AM, Florent Becker <florent.becker at ens-lyon.org
> wrote:

> Mon Sep 28 15:06:19 CEST 2009  Florent Becker <florent.becker at ens-lyon.org
> >
>  * add utility functions to Commands.lhs
>
> Fri Sep 18 14:22:03 CEST 2009  Florent Becker <florent.becker at ens-lyon.org
> >
>  * Haddock documentation for Darcs.Patch.Core.Named
>
> Tue Sep 22 16:30:44 CEST 2009  Florent Becker <florent.becker at ens-lyon.org
> >
>  * typo in Hopefully.lhs
>
> Tue Sep 29 15:50:14 CEST 2009  Florent Becker <florent.becker at ens-lyon.org
> >
>  * remove Darcs.Commands.Loggers
>
> Tue Sep 29 16:04:06 CEST 2009  Florent Becker <florent.becker at ens-lyon.org
> >
>  * Use new Darcs.Commands.Put* in Add
>
> Tue Sep 29 16:24:04 CEST 2009  Florent Becker <florent.becker at ens-lyon.org
> >
>  * Use Darcs.Commands.putVerbose in Apply
>
> Tue Sep 29 16:39:42 CEST 2009  Florent Becker <florent.becker at ens-lyon.org
> >
>  * use Commands.put* in Convert
>
> Tue Sep 29 16:51:48 CEST 2009  Florent Becker <florent.becker at ens-lyon.org
> >
>  * Use Commands.putInfo in Check
>
> Tue Sep 29 17:03:47 CEST 2009  Florent Becker <florent.becker at ens-lyon.org
> >
>  * Use Commands.putInfo in Get
>
> Tue Sep 29 17:16:32 CEST 2009  Florent Becker <florent.becker at ens-lyon.org
> >
>  * Use Commands.putInfo in Push
>
> Wed Sep 30 14:52:15 CEST 2009  Florent Becker <florent.becker at ens-lyon.org
> >
>  * Use Commands.put* in Send
>

My previous objection about missing type-witness signatures seems to be
addressed by removing the refactor that introduced the functions which
needed them.  I haven't fully reviewed the patch, I've just looked for this
one detail.  And what I did see while skimming all seemed fine.

Reinier, do you want to comment again since you reviewed the previous
version of this patch?

Thanks!
Jason
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osuosl.org/pipermail/darcs-users/attachments/20090930/319be4f2/attachment.htm>


More information about the darcs-users mailing list